Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: stop ci test from running vitest in watch mode #6769

Merged
merged 2 commits into from
Sep 19, 2024
Merged

chore: stop ci test from running vitest in watch mode #6769

merged 2 commits into from
Sep 19, 2024

Conversation

edmundhung
Copy link
Member

@edmundhung edmundhung commented Sep 19, 2024 •
edited
Loading

What this PR solves / how to test

Fixes N/A.

This stops ci tests from running vitest in watch mode and reduce the github action timeout time to 30mins.

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: chore
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: chore
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Changeset included
    • Changeset not necessary because: chore
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: chore

@edmundhung edmundhung requested a review from a team as a code owner September 19, 2024 13:00
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 19, 2024

⚠️ No Changeset found

Latest commit: 821dc17

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10941497337/npm-package-wrangler-6769

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6769/npm-package-wrangler-6769

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10941497337/npm-package-wrangler-6769 dev path/to/script.js
Additional artifacts: 
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10941497337/npm-package-create-cloudflare-6769 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10941497337/npm-package-cloudflare-kv-asset-handler-6769
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10941497337/npm-package-miniflare-6769
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10941497337/npm-package-cloudflare-pages-shared-6769
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10941497337/npm-package-cloudflare-vitest-pool-workers-6769
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10941497337/npm-package-cloudflare-workers-editor-shared-6769
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10941497337/npm-package-cloudflare-workers-shared-6769

Note that these links will no longer work once the GitHub Actions artifact expires.

[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240909.3
workerd 1.20240909.0 1.20240909.0
workerd --version 1.20240909.0 2024-09-09

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

petebacondarwin
petebacondarwin approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!

@edmundhung edmundhung merged commit 7e0d83d into main Sep 19, 2024
23 checks passed
@edmundhung edmundhung deleted the edmundhung/improve-packages-ci-test branch September 19, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petebacondarwin petebacondarwin petebacondarwin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edmundhung @petebacondarwin